From 2714e051733835f816957c0aedafcfbb5fb8d6a2 Mon Sep 17 00:00:00 2001 From: Kai Lauterbach Date: Fri, 12 May 2023 07:04:25 +0200 Subject: [PATCH 1/2] Fixed typo in calculation --- firmware/firmware.ino | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/firmware/firmware.ino b/firmware/firmware.ino index 36c6819..676dfd1 100644 --- a/firmware/firmware.ino +++ b/firmware/firmware.ino @@ -162,7 +162,7 @@ void lightEngine() if (current_bri[i] != 0) { in_transition = true; - current_bri[i] -= step_level[i] / BRI_MOD_STEPS_PER_SEC; + current_bri[i] += step_level[i] / BRI_MOD_STEPS_PER_SEC; if (current_bri[i] < 0) { current_bri[i] = 0; From 013cd8a8bfab8ac44297b29a67dcf7ac2dc7699b Mon Sep 17 00:00:00 2001 From: Kai Lauterbach Date: Fri, 12 May 2023 07:19:03 +0200 Subject: [PATCH 2/2] Added a comment --- firmware/firmware.ino | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/firmware/firmware.ino b/firmware/firmware.ino index 676dfd1..3348974 100644 --- a/firmware/firmware.ino +++ b/firmware/firmware.ino @@ -157,7 +157,7 @@ void lightEngine() //Serial.println("lon: pin" + (String)i + " = PWM(" + (String)tmp_pwm + ")"); analogWrite(pins[i], tmp_pwm); } - } else { + } else { // light state is off if (current_bri[i] != 0) {